Skip to content

Maybe support observableArray in markup control properties#1914

Merged
tomasherceg merged 2 commits intomainfrom
maybe-markupcontrol-observablearray
Apr 26, 2025
Merged

Maybe support observableArray in markup control properties#1914
tomasherceg merged 2 commits intomainfrom
maybe-markupcontrol-observablearray

Conversation

@exyi
Copy link
Copy Markdown
Member

@exyi exyi commented Mar 16, 2025

who'd think most of BP is broken without this obscurity...

who'd think most of BP is broken without this obscurity...
@exyi exyi marked this pull request as ready for review April 4, 2025 13:03
Copy link
Copy Markdown
Member

@tomasherceg tomasherceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JS tests

@exyi exyi added this to the Version 5.0 milestone Apr 4, 2025
Including a small fix for return values of the wrapped observableArray
functions, making it possible to use indexOf, splice, etc
@tomasherceg tomasherceg merged commit f698113 into main Apr 26, 2025
14 of 15 checks passed
@tomasherceg tomasherceg deleted the maybe-markupcontrol-observablearray branch April 26, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants